Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix margin and padding issues with CatalogTree table #19950

Merged
merged 2 commits into from
Dec 1, 2022
Merged

Fix margin and padding issues with CatalogTree table #19950

merged 2 commits into from
Dec 1, 2022

Conversation

edmundito
Copy link
Contributor

@edmundito edmundito commented Nov 30, 2022 •
edited
Loading

What

Resolves #19874
Closes #19924

Fixes many issues with the margin and padding in the CatalogTree table:

  • Fixes the field table left margin not quite aligning with the row
  • Fixes the bottom margin of the field table
  • Fixes padding issues around the table and simplifies check between old table and new table

Before:
image

Problem areas:
fixes

After:

image

How

This approach favors the parent pushing the content inward with padding over the content making margin for themselves.
There is a hotfix for specific situation that was too convoluted to fix. Noted in comments.

@edmundito
Fix margin and padding issues with CatalogTree table
7dda4f2 
Update to use padding over the margin
Fix fields table offset left margin
Fix fields table padding and bottom margin
@edmundito edmundito requested a review from a team as a code owner November 30, 2022 22:02
@octavia-squidington-iv octavia-squidington-iv added area/platform issues related to the platform area/frontend Related to the Airbyte webapp labels Nov 30, 2022
krishnaglick
krishnaglick reviewed Nov 30, 2022
View reviewed changes
Copy link
Contributor

@krishnaglick krishnaglick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good. Would like to test locally before approval.

josephkmh
josephkmh approved these changes Dec 1, 2022
View reviewed changes
Copy link
Contributor

@josephkmh josephkmh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me - tested locally and did not see any issues ✨

airbyte-webapp/src/components/connection/CatalogTree/StreamFieldTable.module.scss Show resolved Hide resolved
@krishnaglick
Copy link
Contributor

Build failing on snapshot changes. Maybe test should be its own runner?

@edmundito edmundito merged commit 31c7109 into master Dec 1, 2022
@edmundito edmundito deleted the edmundito/fix-catalogtree-table-spacing branch December 1, 2022 17:54
@github-actions github-actions bot mentioned this pull request Dec 2, 2022
Closed
This was referenced Dec 6, 2022
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krishnaglick krishnaglick krishnaglick left review comments

@josephkmh josephkmh josephkmh approved these changes

Assignees
No one assigned
Labels
area/frontend Related to the Airbyte webapp area/platform issues related to the platform
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Connection streams vertical and right margin do not align with other cards
4 participants
@edmundito @krishnaglick @josephkmh @octavia-squidington-iv